current community

your communities

more stack exchange communities

company blog
Stack Exchange Inbox Reputation and Badges
tour help
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. Join them; it only takes a minute:

Sign up
Here's how it works:
  1. Anybody can ask a question
  2. Anybody can answer
  3. The best answers are voted up and rise to the top
up vote 2 down vote favorite

Call from my index.php to function get_data($curr_date) goes from here

case "events" :
                    $curr_date = $_POST['current_date'];
                    if ( $eid = get_data($curr_date) )
                        {

                            $result = array( "success"=>true,  
                            "eid"=>$eid);

                            $json_output = json_encode( $result );
                            echo $json_output;
                        }
                        else
                            echo FAIL;

    break;

    enter code here

This is my function which returns the result

function get_data($curr_date)
{
    $events_list = mysql_query( "SELECT eid, display_date, word_of_the_day, word_of_the_day_meaning, thought_of_the_day, 
    crazyFact_of_the_day, joke_of_the_day FROM eventsoftheday WHERE display_date = '$curr_date' "); 
                                // get mysql result cursor
    if( mysql_num_rows( $events_list )  > 0 ) // check if the query returned any records
    {
        $mysql_record = mysql_fetch_array( $events_list );    // parse mysql result cursor
        $events = array();
         $events['e_id'] = $mysql_record['eid'];
         $events['edisplay_date'] = $mysql_record['display_date'];
         $events['eword_of_the_day'] = $mysql_record['word_of_the_day'];
         $events['eword_of_the_day_meaning'] = $mysql_record['word_of_the_day_meaning'];
         $events['ethought_of_the_day'] = $mysql_record['thought_of_the_day'];
         $events['ecrazyFact_of_the_day'] = $mysql_record['crazyFact_of_the_day'];
         $events['ejoke_of_the_day'] = $mysql_record['joke_of_the_day'];

        return $events;     // return events

    }
    else
        return false;
}
share|improve this question
up vote 1 down vote

Maybe it's better to return error in JSON (if FAIL constant isn't JSON yet)

echo json_encode(array('result' => false));

instead of

echo FAIL;

or return HTTP error code

header('HTTP/1.1 500 Internal Server Error');

And we can simplifify function get_data like this:

if(mysql_num_rows( $events_list )) // check if the query returned any records
{
    $mysql_record = mysql_fetch_array( $events_list );    // parse mysql result cursor
    return array(
        'e_id'                     => $mysql_record['eid'],
        'edisplay_date'            => $mysql_record['display_date'],
        'eword_of_the_day'         => $mysql_record['word_of_the_day'],
        'eword_of_the_day_meaning' => $mysql_record['word_of_the_day_meaning'],
        'ethought_of_the_day'      => $mysql_record['thought_of_the_day'],
        'ecrazyFact_of_the_day'    => $mysql_record['crazyFact_of_the_day'],
        'ejoke_of_the_day'         => $mysql_record['joke_of_the_day'],
    );
} else return false;
share|improve this answer
    
thank u sir but .. my issue got solved using above method – user2604422 Mar 5 '14 at 3:35

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.