BF: process included files before the rest #700

yarikoptic · 2017-11-27T22:18:24Z

Alternative solution to #628 - may be I have missed why it was more complex than 1 line change? ;)

Closes #627
includes test
also some minor refactoring to tests.lib to provide SkipTest, and skipIf

It also includes disabled (well -- raises SkipTest) for the fact that in current logic processing of included files is done not right at the point of inclusion. That makes it behave differently from stock git config


          version up

Fixes #637


          Merge tag '2.1.7' into bf-version so VERSION content is appropriate


          BF: process included files before the rest


          Merge pull request #699 from yarikoptic/bf-version

Merged 2.1.7 into master (just VERSION changes)


          BF: wrap map into list, since iterator is not well digested by GitCon…

…figParser

codecov-io · 2017-11-28T01:01:30Z

Codecov Report

Merging #700 into master will increase coverage by 1.82%.
The diff coverage is 93.24%.

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   92.83%   94.65%   +1.82%     
==========================================
  Files          61       60       -1     
  Lines       10152     9344     -808     
==========================================
- Hits         9425     8845     -580     
+ Misses        727      499     -228

Impacted Files	Coverage Δ
git/test/test_submodule.py	`99.23% <ø> (+1.71%)`	⬆️
git/refs/log.py	`93.84% <0%> (ø)`	⬆️
git/repo/base.py	`95.96% <0%> (+0.67%)`	⬆️
git/config.py	`92.76% <100%> (+0.32%)`	⬆️
git/test/test_util.py	`98.52% <100%> (+10.29%)`	⬆️
git/diff.py	`99.11% <100%> (ø)`	⬆️
git/exc.py	`96.42% <100%> (ø)`	⬆️
git/test/test_config.py	`98.33% <100%> (+0.08%)`	⬆️
git/compat.py	`65.03% <100%> (+0.21%)`	⬆️
git/test/test_commit.py	`100% <100%> (ø)`	⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cd130...0a6cb4a. Read the comment docs.


          RF: primarily flake8 lints + minor RF to reduce duplication in PATHEXT

I did keep some "bare" except with catch all Exception: , while tried to disable flake8 complaints where clearly all exceptions are to be catched


          BF(PY26): {} -> {0}, i.e. explicit index for .format()


          BF: crazy tests ppl pass an object for status... uff -- catch TypeErr…

…or too


          RF: last of flake8 fails - avoid using temp variable in a test


          RF(+BF?): refactor hooks creation in a test, and may be make it compa…

…t with windows


          ENH: add appveyor recipe to establish rdesktop login into the test box


          ENH: also report where on sh, and echo msg when entering on_finish


          RF: no "need" for custom shebang on windows since just does not work


          Disable (but keep for future uses commented out) hook into appveyor s…

…ession


          RF(TST): skip all tests dealing with hooks on windows


          BF(WIN): use where instead of which while looking for git


          RF: use HIDE_WINDOWS_KNOWN_ERRORS instead of is_win to skip hooks tests


          BF(WIN): where could report multiple hits, so choose first

yarikoptic · 2017-11-28T20:42:45Z

I guess I will wait for #702 to be merged first so we could get travis pass here as well


          to keep travis busy - adding myself to AUTHORS


          Merge pull request #702 from yarikoptic/bf-happy-travis

BF (codename "happy travis"): trying to address lints etc to make Travis green again


          Merge branch 'bf-includes' of https://github.com/yarikoptic/GitPython …

…into yarikoptic-bf-includes

Byron · 2017-12-11T14:27:58Z

@yarikoptic As always, thanks so much for chiming in :)! I merged the referenced 'make travis happy' branch in, and it seems to work just fine.

Byron and others added 3 commits Sep 28, 2017

version up

Unverified

This user has not uploaded their public key yet.

GPG key ID: 9FEE1C6A3B07188F Learn about signing commits

Loading status checks…

ccff34d

Fixes #637

Merge tag '2.1.7' into bf-version so VERSION content is appropriate

Loading status checks…

d78e368

BF: process included files before the rest

Loading status checks…

cd6e82c

yarikoptic mentioned this pull request Nov 27, 2017

included config files should be processed right away, and not just after the current file is already loaded #701

Open

yarikoptic added 2 commits Nov 27, 2017

BF: wrap map into list, since iterator is not well digested by GitCon…

Loading status checks…

d2c1d19

…figParser

yarikoptic added 13 commits Nov 28, 2017

RF: primarily flake8 lints + minor RF to reduce duplication in PATHEXT

6ee08fc

I did keep some "bare" except with catch all Exception: , while tried to disable flake8 complaints where clearly all exceptions are to be catched

BF(PY26): {} -> {0}, i.e. explicit index for .format()

Loading status checks…

086af07

BF: crazy tests ppl pass an object for status... uff -- catch TypeErr…

Loading status checks…

e1aea3a

…or too

RF: last of flake8 fails - avoid using temp variable in a test

Loading status checks…

c352dba

RF(+BF?): refactor hooks creation in a test, and may be make it compa…

Loading status checks…

42e89cc

…t with windows

ENH: add appveyor recipe to establish rdesktop login into the test box

Loading status checks…

d723148

ENH: also report where on sh, and echo msg when entering on_finish

Loading status checks…

dcfe242

RF: no "need" for custom shebang on windows since just does not work

0a67f25

Disable (but keep for future uses commented out) hook into appveyor s…

6253625

…ession

RF(TST): skip all tests dealing with hooks on windows

91b9bc4

BF(WIN): use where instead of which while looking for git

Loading status checks…

b4459ca

RF: use HIDE_WINDOWS_KNOWN_ERRORS instead of is_win to skip hooks tests

cc34077

BF(WIN): where could report multiple hits, so choose first

Loading status checks…

4d851a6

yarikoptic and others added 3 commits Dec 1, 2017

to keep travis busy - adding myself to AUTHORS

Loading status checks…

f48d087

Merge branch 'bf-includes' of https://github.com/yarikoptic/GitPython …

Unverified

This user has not uploaded their public key yet.

GPG key ID: 665F99FA9D99966C Learn about signing commits

Loading status checks…

0a6cb4a

…into yarikoptic-bf-includes

Byron merged commit 03126bf into gitpython-developers:master Dec 11, 2017
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

yarikoptic deleted the yarikoptic:bf-includes branch Dec 15, 2017

gitpython-developers / GitPython

BF: process included files before the rest #700

BF: process included files before the rest #700

yarikoptic commented Nov 27, 2017

codecov-io commented Nov 28, 2017 •

edited

yarikoptic commented Nov 28, 2017

Byron commented Dec 11, 2017

gitpython-developers / GitPython

Join GitHub today

BF: process included files before the rest #700

BF: process included files before the rest #700

Conversation

yarikoptic commented Nov 27, 2017

codecov-io commented Nov 28, 2017 • edited

Codecov Report

yarikoptic commented Nov 28, 2017

Byron commented Dec 11, 2017

codecov-io commented Nov 28, 2017 •

edited