Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): make short options with arguments become two separate argum… #341

Merged
merged 2 commits into from Aug 21, 2015

Conversation

@StyXman
Copy link
Contributor

@StyXman StyXman commented Aug 19, 2015

…ents for the executable.

So git.Git.command(f=42) becomes git command -f 42 instead of git command -f42, which is not recognized by git. See #340.

…ents for the executable.
@StyXman StyXman mentioned this pull request Aug 19, 2015
@Byron Byron added this to the v1.0.2 - Fixes milestone Aug 21, 2015
@Byron
Copy link
Member

@Byron Byron commented Aug 21, 2015

Thank you !

Please note that the tests require some runup on the local repository, what's done exactly can be seen in the .travis.yml file.

Byron added a commit that referenced this pull request Aug 21, 2015
fix(cmd): make short options with arguments become two separate argum…
@Byron Byron merged commit 1d768f6 into gitpython-developers:master Aug 21, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Shrews

This comment has been minimized.

Copy link

@Shrews Shrews commented on 332521a Feb 12, 2016

FYI, I believe this breaks diff functionality. Using git 2.5.4 on OS X and it insists that the -U option not have a space between the option and the value. 1.0.2 is broken b/c of this.

This comment has been minimized.

Copy link
Contributor Author

@StyXman StyXman replied Feb 15, 2016

I confirm that this is the case. Somehow it's git's fault, but trying to push a change there would be more difficult. Maybe this should be reverted? :(

This comment has been minimized.

Copy link

@Shrews Shrews replied Feb 15, 2016

Discussion of the problem in issue #382

@Byron Byron mentioned this pull request Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.