Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version property to PostgresNode #49

Merged
merged 3 commits into from Jun 26, 2018

Conversation

@ildus
Copy link
Collaborator

@ildus ildus commented Jun 25, 2018

No description provided.

ildus added 2 commits Jun 25, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 25, 2018

Codecov Report

Merging #49 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   97.17%   97.18%   +0.01%     
==========================================
  Files          17       17              
  Lines        1556     1564       +8     
==========================================
+ Hits         1512     1520       +8     
  Misses         44       44
Impacted Files Coverage Δ
tests/test_simple.py 99.81% <100%> (ø) ⬆️
testgres/node.py 97.07% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a3e55...95b5c5d. Read the comment docs.

@funbringer funbringer self-requested a review Jun 25, 2018
@funbringer
Copy link
Collaborator

@funbringer funbringer commented Jun 25, 2018

Looks like your test is failing on python 2.7.

@funbringer funbringer merged commit c187ccb into postgrespro:master Jun 26, 2018
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 97.17%)
Details
codecov/project 97.18% (+0.01%) compared to 80a3e55
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@funbringer
Copy link
Collaborator

@funbringer funbringer commented Jun 26, 2018

Looks good to me, merged.

@ildus ildus deleted the ildus:version_property branch Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.