Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin github actions virtual environment versions #573

Merged
merged 1 commit into from Nov 27, 2020
Merged

Conversation

@umbynos
Copy link
Collaborator

@umbynos umbynos commented Nov 26, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
  • What is the current behavior?

ubuntu-latest will be an alias to ubuntu-20.04 instead of ubuntu-18.04 actions/virtual-environments#1816

  • What is the new behavior?

I've pinned github actions virtual environments to an explicit version to not get unexpected behaviours.

  • Does this PR introduce a breaking change?

no

  • Other information:
@umbynos umbynos self-assigned this Nov 26, 2020
@umbynos umbynos added the CI label Nov 26, 2020
@umbynos umbynos requested a review from zmoog Nov 27, 2020
@zmoog
zmoog approved these changes Nov 27, 2020
Copy link
Collaborator

@zmoog zmoog left a comment

LGTM

@umbynos umbynos merged commit d71d3ec into devel Nov 27, 2020
3 checks passed
3 checks passed
test-matrix (ubuntu-18.04)
Details
test-matrix (windows-2019)
Details
test-matrix (macos-10.15)
Details
@umbynos umbynos deleted the umbynos/pin_gh_runners branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.