Skip to content

/ gallery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhide gradient #312

Merged
merged 2 commits into from Sep 17, 2020
Merged

Unhide gradient #312

merged 2 commits into from Sep 17, 2020

Conversation

@pennzht
Copy link
Member

@pennzht pennzht commented Sep 17, 2020

Remove hide Gradient from the import directive in reference/transformations_demo_board.dart.

Explanation

The file reference/transformations_demo_board.dart imports package:flutter/material.dart and hides Gradient, but Gradient is never defined or used in the file, so removing it should have no effect.

We make this change so that the DartPad code generator can handle import directives better.
pennzht added 2 commits Sep 17, 2020
@pennzht
Unhide Gradient.
1f24803
@pennzht
Update code segments.
6450020
@pennzht pennzht requested a review from guidezpl Sep 17, 2020
@JoseAlba
JoseAlba approved these changes Sep 17, 2020
View changes
Copy link
Contributor

@JoseAlba JoseAlba left a comment 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝
@guidezpl
guidezpl approved these changes Sep 17, 2020
View changes
Copy link
Member

@guidezpl guidezpl left a comment 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
@pennzht pennzht merged commit 5f62809 into flutter:master Sep 17, 2020
7 checks passed
7 checks passed
@github-actions
Golden tests
Details
@github-actions
Integration tests
Details
@github-actions
Test on ubuntu-latest
Details
@github-actions
Test on windows-latest
Details
@github-actions
Test on macos-latest
Details
@wip
WIP Ready for review
Details
@googlebot
cla/google All necessary CLAs are signed
@pennzht pennzht deleted the pennzht:unhide-gradient branch Sep 17, 2020
gspencergoog pushed a commit to gspencergoog/gallery that referenced this pull request Sep 23, 2020
@guidezpl
[Gallery] Fix directory structure (flutter#312)
2f803eb 
Former-commit-id: 312ddf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl

@JoseAlba JoseAlba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pennzht @guidezpl @JoseAlba