React to MSBuild Traversal and NoTargets SDK updates #52895
Conversation
The rebuild target was added into the Traversal SDK here: microsoft/MSBuildSdks@fd7660d#diff-ad560c0828c6bab536a01e43bb052bfce14a959b8df2c3f89cccfca0b399681c
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe rebuild target was added into the Traversal SDK here: microsoft/MSBuildSdks@fd7660d#diff-ad560c0828c6bab536a01e43bb052bfce14a959b8df2c3f89cccfca0b399681c
|
ViktorHofer
requested review from
EgorBo,
imhameed,
marek-safar,
SamMonoRT and
vargaz
as code owners
ViktorHofer
changed the title
| @@ -10,6 +11,6 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Content Include="*.cs" PackagePath="contentFiles/cs/netstandard1.0/%(FileName)%(Extension)" /> | |||
| <Content Include="*.cs" PackagePath="contentFiles/cs/netstandard1.0/%(FileName)%(Extension)" BuildAction="Compile" /> | |||
There was a problem hiding this comment.
@Anipik I checked the generated package's nuspec and before this change there were two items added as following:
- one content item for netstandard1.0 without a compile build action
- one compile item added for netstandard2.0
I assume that the content item was unintentional? The package wouldn't have worked and participated in the user's build for netstandard1.x targets. That said, I plan to trim assets from our packages which includes netstandard1.x assets so this might go away entirely.
There was a problem hiding this comment.
I assume that the content item was unintentional?
thats unintentinal
|
The PR is ready for review, PTAL. |
$(NetCoreAppToolCurrent)as the tfm, except for projects which package or participate in the traversal TargetFramework.Sdk filtering.