MarcoFalke
Follow
MarcoFalke
Follow
Pinned
6,120 contributions in the last year
Less
More
Contribution activity
April 2022
Created 65 commits in 5 repositories
Created a pull request in bitcoin/bitcoin that received 37 comments
Change code
This changes the code. PoS has several outstanding problems, see for example section 4.2 "Costless Simulation" of https://download.wpsoftware.net/b…
+3
−3
•
37
comments
Opened 12 other pull requests in 2 repositories
bitcoin/bitcoin
6
merged
2
closed
2
open
- doc: Convert remaining comments to clang-tidy format
- doc: Merge release note snippets for 24.0
- ci: Build all optional dependencies in tidy task
- lint: Start to use py lint scripts
- Disable the syscall sandbox for bitcoin-qt and remove gui-related syscalls
- ci: Add clang-tidy task
- refactor: Remove ParseHex(const char*) from public interface
- test: Fix intermittent test failure in wallet_listreceivedby.py
- Remove taproot chain param
- Remove buggy and confusing IncrementExtraNonce
sipa/miniscript
2
merged
Reviewed 24 pull requests in 1 repository
bitcoin/bitcoin
24 pull requests
- util/check: Replace CHECK_NONFATAL macro with identity function and use it in src/rpc
- refactor address relay time
-
Modernize util/strencodings and util/string:
string_viewandoptional - Sanity assert GetAncestor() != nullptr where appropriate
- Rename message_command variables in src/net* and src/rpc/net.cpp
- lint: convert submodule linter test to Python
- refactor: use Span in random.*; make GetRand a template, remove GetRandInt
- lint: Convert Python linter to Python
- scripted-diff: Regenerate key_io data deterministically
- wallet: BIP 326 sequence based anti-fee-snipe for taproot inputs
- rpc: add rpc to get mempool txs spending specific prevouts
- lint: convert spellchecking lint test to python
- lint: Convert Python dead code linter test to Python
- Remove taproot chain param
-
build: Do not define
PROVIDE_FUZZ_MAIN_FUNCTIONmacro unconditionally - Replace uint256 specific implementations of base_uint::GetHex() and base_uint::SetHex() with proper ones that don't depend on uint256
- test: use MiniWallet for mempool_unbroadcast.py
- Disable the syscall sandbox for bitcoin-qt and remove gui-related syscalls
- Remove buggy and confusing IncrementExtraNonce
- test: Fix intermittent test failure in wallet_listreceivedby.py
- refactor: Remove ParseHex(const char*) from public interface
- ci: use DWARF-4 for Valgrind jobs
-
Put lock contention logging behind
DEBUG_LOCKCONTENTIONpreprocessor directive - Enforce Taproot script flags whenever WITNESS is set
Created an issue in google/oss-fuzz that received 4 comments
bitcoin-core: Coverage build started failing on April 2nd
See https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46316 I wonder if there are any upstream changes that caused this? Maybe a stricter timeout?
4
comments