Skip to content

[WIP] Remove wrapper from pointer tensor#3443

Closed
gmuraru wants to merge 3 commits intoOpenMined:masterfrom
gmuraru:gm-remove-wrapper
Closed

[WIP] Remove wrapper from pointer tensor#3443
gmuraru wants to merge 3 commits intoOpenMined:masterfrom
gmuraru:gm-remove-wrapper

Conversation

@gmuraru
Copy link
Member

@gmuraru gmuraru commented May 3, 2020

Description

Remove wrapper from PointerTensor.

Type of change

Please mark the options that are relevant.

  • Added/Modified tutorials
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@gmuraru gmuraru requested a review from a team May 3, 2020 17:11
@karlhigley karlhigley linked an issue May 12, 2020 that may be closed by this pull request
@gmuraru gmuraru force-pushed the gm-remove-wrapper branch from 5540f09 to 70b1302 Compare May 18, 2020 08:37
@gmuraru
Copy link
Member Author

gmuraru commented May 18, 2020

The tests are passing for the pointer tensor, but fail for the others :( -- need to look into that

@karlhigley karlhigley force-pushed the gm-remove-wrapper branch from 801f0c3 to 41284c2 Compare May 21, 2020 17:23
@iamtrask
Copy link
Member

Hey George - let’s sync on this. I think there’s a cleaner approach to this refactor. Book a meeting with me using calendly

@karlhigley
Copy link
Contributor

We’re burning this candle from several ends now, since the AbstractSendable work is also aimed at this goal. 👍

@github-actions
Copy link

This pull request has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.

@github-actions github-actions bot added the Status: Stale 🍞 Been open for a while with no activity label Jun 29, 2020
@github-actions github-actions bot closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Stale 🍞 Been open for a while with no activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove wrapper from Custom Tensors

3 participants