[WIP] Remove wrapper from pointer tensor#3443
Closed
gmuraru wants to merge 3 commits intoOpenMined:masterfrom
Closed
[WIP] Remove wrapper from pointer tensor#3443gmuraru wants to merge 3 commits intoOpenMined:masterfrom
gmuraru wants to merge 3 commits intoOpenMined:masterfrom
Conversation
5540f09 to
70b1302
Compare
Member
Author
|
The tests are passing for the pointer tensor, but fail for the others :( -- need to look into that |
801f0c3 to
41284c2
Compare
Member
|
Hey George - let’s sync on this. I think there’s a cleaner approach to this refactor. Book a meeting with me using calendly |
Contributor
|
We’re burning this candle from several ends now, since the |
|
This pull request has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove wrapper from PointerTensor.
Type of change
Please mark the options that are relevant.
Checklist: