Optimize build flow, divide default build into release build and debu…#2288
Closed
JesseCodeBones wants to merge 1 commit intoAssemblyScript:mainfrom
Closed
Optimize build flow, divide default build into release build and debu…#2288JesseCodeBones wants to merge 1 commit intoAssemblyScript:mainfrom
JesseCodeBones wants to merge 1 commit intoAssemblyScript:mainfrom
Conversation
…g build Signed-off-by: Jesse <xiang19890319@gmail.com>
dcodeIO
reviewed
May 26, 2022
Comment on lines
+13
to
+14
| const debug = process.argv[2] === "--debug"; | ||
| const release = process.argv[2] === "--release"; |
Member
There was a problem hiding this comment.
Should there perhaps be a default here if no build type is specified? Seems that right now this would result in debug = false and release = false. For example:
Suggested change
| const debug = process.argv[2] === "--debug"; | |
| const release = process.argv[2] === "--release"; | |
| const debug = process.argv[2] === "--debug"; | |
| const release = process.argv[2] === "--release" || !debug; |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions! |
|
This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run build:debugmeans debug version (un-minified js files, contains the source maps)npm run build:releasemeans release version (source maps without source content, minified js files)issue link:
#2286
Signed-off-by: Jesse xiang19890319@gmail.com